Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python < 3.6 for opencensus-ext-stackdriver #1056

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Aug 2, 2021

Drop support for Python versions < 3.6 (breaking change) for opencensus-ext-stackdriver. This is in preparation for upgrading to the google-cloud-monitoring ~= 2.0

  • Update setup.py classifiers and python_requires
  • Update tox.ini to only include this package in compatible python version builds

Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the next release going to bump the minor version?

@aabmass
Copy link
Member Author

aabmass commented Aug 3, 2021

Is the next release going to bump the minor version?

Yes that would be ideal. Are we able to version these packages separately or you want to keep them all in lockstep?

@google-cla
Copy link

google-cla bot commented Aug 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Aug 3, 2021
@aabmass
Copy link
Member Author

aabmass commented Aug 3, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Aug 3, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@lzchen
Copy link
Contributor

lzchen commented Aug 3, 2021

@aabmass
Azure is already not in lockstep so I'm totally fine in bumping the stackdriver version. As well, we release stuff manually too (no script) so no advantage in having them all the same version either.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@aabmass
Copy link
Member Author

aabmass commented Aug 3, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Aug 3, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 3, 2021
@google-cla
Copy link

google-cla bot commented Aug 3, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@aabmass aabmass merged commit 98567b3 into census-instrumentation:master Aug 3, 2021
@aabmass aabmass deleted the tox-for-gcm-update branch August 3, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants